sheerun / prettier-standard

Formats with Prettier and lints with ESLint+Standard! (✿◠‿◠)
MIT License
868 stars 44 forks source link

Doesn't show all `standard` errors #14

Closed josephfrazier closed 7 years ago

josephfrazier commented 7 years ago

First off, thanks for building this! It's a very easy way to have the linting of standard with the formatting of prettier :)

However, prettier-standard doesn't show the same errors that standard does. For example, in the prettier-standard repo at commit 54948a5 (with prettier-standard linked globally):

$ prettier-standard src/format-files.js
1 file was unchanged
$ standard src/format-files.js
standard: Use JavaScript Standard Style (https://standardjs.com)
  /Users/josephfrazier/workspace/prettier-standard/src/format-files.js:39:10: 'coercePath' is defined but never used.
$
sheerun commented 7 years ago

Prettier-standard is a formatter, not linter. It shouldn't show any errors, just format :)

On Wed, 10 May 2017 at 18:45, Joseph Frazier notifications@github.com wrote:

First off, thanks for building this! It's a very easy way to have the linting of standard with the formatting of prettier :)

However, prettier-standard doesn't show the same errors that standard does. For example, in the prettier-standard repo at commit 54948a5 https://github.com/sheerun/prettier-standard/commit/54948a54a3113e52d46e4c14d2e30eb27cc3bba9 (with prettier-standard linked globally):

$ prettier-standard src/format-files.js 1 file was unchanged $ standard src/format-files.js standard: Use JavaScript Standard Style (https://standardjs.com) /Users/josephfrazier/workspace/prettier-standard/src/format-files.js:39:10: 'coercePath' is defined but never used. $

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sheerun/prettier-standard/issues/14, or mute the thread https://github.com/notifications/unsubscribe-auth/AAR2DWvlhwN8-Oj6MBNgKrjvDE_5HqwCks5r4em9gaJpZM4NW71_ .

josephfrazier commented 7 years ago

Ah, I misunderstood. From the name, I had assumed that it would also lint.