search

sheerun / prettier-standard

Formats with Prettier and lints with ESLint+Standard! (✿◠‿◠)
MIT License
868 stars 44 forks source link

Standard 12 #63

Closed timdp closed 5 years ago

timdp commented 6 years ago

Now that standard@12 is out, it'd be awesome if this package could be updated to use that.

I've been locking down my version of standard to 10 because using version 11 broke stuff. I'm guessing version 12 isn't going to be any better.

Is there a formal to-do list for upgrading? I assume it involves upgrading eslint-config-standard as well as eslint itself?

Thanks!

billiegoose commented 6 years ago

Version 11 of standard worked for me with prettier-standard but v12 broke it: https://github.com/standard/standard/issues/1163

lannonbr commented 6 years ago

The issue with Standard 11 was a deep dependency issue was arising when ESLint 4.x and 5.x were both installed. As long as all of the packages which depend on ESLint are up to 5.x, it should be fine

billiegoose commented 6 years ago

But prettier-standard has a direct dependency on eslint 4.x which is why it's breaking I think.

timdp commented 6 years ago

That, and I was able to create a situation where prettier-standard produced code that passed Standard v10 and failed v11. Unfortunately, I didn't save it.

Kikobeats commented 5 years ago

any idea how we can move this forward?

I have a lot of projects blocked at standard@11 because yes, probably we can create a PR for migrating from 11 to 12.

sheerun commented 5 years ago

You can send PR to prettier-eslint that adds support for eslint 5: https://github.com/prettier/prettier-eslint/issues/193

sheerun commented 5 years ago

prettier-standard 9.0.0 no longer uses eslint --fix (or standard --fix) for formatting so it is not relevant now