Wrong formatting of the trick for generics in tsx

[havenchyk]

I'm not sure should it be solved here on at prettierx.

<T,>(props: Props<T>) => {} will be fomatted without a space: <T,>, but standard adds this space.

Related issue https://github.com/brodybits/prettierx/issues/107

[sheerun]

We use prettierx so it needs to be fixed there first

[havenchyk]

@sheerun what do you think if we disable rule comma-spacing from eslint if it's covered by prettier(x?)

[sheerun]

Sorry I’m not fluent with what prettier can do :)

On Wed, 15 Jan 2020 at 08:43, Uladzimir Havenchyk notifications@github.com wrote:

@sheerun https://github.com/sheerun what do you think if we disable rule comma-spacing from eslint if it's covered by prettier(x?)

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/sheerun/prettier-standard/issues/94?email_source=notifications&email_token=AACHMDLZURADH4XH5BSKSM3Q525A3A5CNFSM4KGX6VN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI7LVGI#issuecomment-574536345, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACHMDKULVTG53Z7WIGHKLTQ525A3ANCNFSM4KGX6VNQ .

[sheerun]

@havenchyk I see what you mean now. I think best option is to send PR to https://github.com/prettier/eslint-config-prettier which we use

[sheerun]

Actually it seems it was sent already: https://github.com/prettier/eslint-config-prettier/commit/04c79bf1602c8126da863d0997aef5ff347b73db

[sheerun]

I've updated all vendor dependencies and published as 16.2.0, maybe you could check if you have time

[havenchyk]

Nice, thanks @sheerun, I'll check it. I migrated my codebase to T extends unknown. See who started it 😄?