sheerun / vim-polyglot

A solid language pack for Vim.
5.6k stars 296 forks source link

Support older VIM without syn iskeyword #816

Open vcargats opened 2 years ago

vcargats commented 2 years ago

syn iskeyword was added in 7.4.1142. This adds a fallback to 'setlocal iskeyword'.

sheerun commented 2 years ago

I'd suggest changing build script so syn is replaced by setlocal iskeyword in all files automatically during build

vcargats commented 2 years ago

hm... I have checked other syntax files. It turns out that a half of those which use 'syn iskeyword' already have a fallback.

So these are that have the fallback: blade.vim mapple.vim pgsql.vim bicep.vim hcl.vim lisp.vim

And these are that don't have: pf.vim crystal.vim html.vim awk.vim dune.vim svelte.vim mf.vim debcontrol.vim kabal.vim tydy.vim

Now I can modify the build script and replace just the files that do not yet have the fallback.

Or I may create corresponding PRs for the original syntax files if their repos still exist/supported, so that new versions will be eventually pulled into this repo. css.vim for example is deprecated, so I think I need to change that here.

What do you think?

sheerun commented 2 years ago

Build script is the easiest way, but you can send PRs to other repos if you want it. I've just pushed updated build

vcargats commented 2 years ago

Your latest commit does not have build script. So you were going to replace that by yourself? I just didn't understand.

sheerun commented 2 years ago

No, go ahead. I meant it just as in "For your information"