search

sheexiong / pe

0 stars 0 forks source link

The redo command sometimes does not work. #4

Open sheexiong opened 4 years ago

sheexiong commented 4 years ago

First I use list deck command.

image.png

Then when I use redo, it does not work.

image.png

nus-pe-bot commented 4 years ago

Team's Response

This is not a bug.

Firstly, from the images you have provided, you are trying to redo a "list" command. The "redo" command is only supposed to redo an "undo" command. For example, if you delete a deck and you decided to undo the deletion of the deck and you suddenly decide you actually do want to delete the deck, you can simply redo the last command, which is like undoing the "undo" command, instead of typing "delete deck DECK_INDEX" again.

Secondly, the "list" command is not a valid command that can be undone. The undo command only undoes commands that interacts and changes deck objects (E.g. adding a deck, clearing all decks). As the list command merely alters what decks are currently being displayed and does not physically alter the deck, the list command cannot be undone. This means that even if you did use "list", then "undo" then "redo", this sequence of commands are still invalid because the "list" command cannot be undone which implies there is no command to be redone.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Here is the only source of the description for the redo command: image.png

And here is the description for the list command: image.png

First, the given description for the redo command is "Redoes latest deck-level command". Based on my understanding, this means that it will redo any command regarding the deck which I previously type.

Second, the given description for the list command is "Shows a list of all the decks in the library and hides the displayed cards (if any)". Based on my understanding, this means that it will list all of the decks in the library which implies that this is a "deck-level command".

Based on the above understanding, as a tester, I assume that the redo command able to redo the list command. Furthermore, there is no any description related to the redo command state that "The “redo” command is only supposed to redo an “undo” command" in the given response which lead me to think that the redo command able to list the decks again.

So my conclusion for this issue is this is still a bug. From the tester point of view, I will not know that I only can "redo" an "undo" command. I also cannot tell which of the command is "deck-level command" as this term only used in the redo and undo command. There is no other description to let me understand which command is "deck-level command" and which is not.