search

shehankonecranes / sp-react-native-mqtt

MQTT Client native module for react-native
68 stars 55 forks source link

Added iOS implementation for isConnected + new features #16

Closed spit4520 closed 3 years ago

spit4520 commented 3 years ago

Added in iOS implementation of isConnected

Also added in functions to get all topics and their current qos. Added in function in order to check if subscribed to specific topic.

Interested in fixing other issues with project and adding in async support

SudoPlz commented 3 years ago

Hey @spit4520 that looks good, thanks for your contribution. Can you add yourself as one of the maintainers (or collaborators) instead of deleting my information in package.json please?

Also, do you want me to invite you as a collaborator? Are you willing to help maintain this library?

Thanks

spit4520 commented 3 years ago

Hey @SudoPlz My mistake, I will update the information.

And yes I would like to help maintain this package, we use it a lot at work and will be adding new features to fit our needs (and share them back) I would appreciate becoming a maintainer.

Look out for my fix to package.json

SudoPlz commented 3 years ago

Sounds good man, just added you :) Thanks for all your hard work.

SudoPlz commented 3 years ago

I noticed some indentation/tab/spacing issues in the package.json file and in the index.js file.

Let me know when this will be ready for another look.

(if you're using vscode check trimTrailingWhitespace out, it saved me so many times)

spit4520 commented 3 years ago

I am using vim, I will fix my tab stopping. Thanks for the heads up!

spit4520 commented 3 years ago

Hey @SudoPlz I just noticed that the version number in package.json is: 0.4.27 but NPM is reporting the latest version to be: 0.5.0 will this cause any conflicts?

SudoPlz commented 3 years ago

damn, my bad! I just forgot to push after publishing..