Closed shehankonecranes closed 4 months ago
Hi SudoPlz,
Yes would like to. I just modified some native code to accept p12 certificate as base64 string and also ca.crt as base64 string. Maybe we can keep this branch as a separate fork. without merging to master.
No I think the proper way to do it, is to make sure this library can work with and without p12, I don't think we should need separate branches or projects for that.
I've added you as a collaborator and I'm planning to transfer the repository to you, all I'd like in return is just:
Is that ok?
Okay sounds good.
I will update the readme now
@SudoPlz updated.
Ι tried transferring the repo but it says this:
Try deleting your repo perhaps? (just make sure you don't lose the changes you made)
@SudoPlz I deleted the repo, can you try now
I initiated the transfer
Okay once it's transferred, what is the next step? Do I need to create a PR again
Afterwards, the repo is yours. I'd create a second PR and only when you're ready to release feel free to merge and rollout a new version on npm. If it's a breaking change bump the major version and consider adding some migration steps on the readme.
Okay nice. will release a version
hey there, is your plan to become a maintainer for this library? I noticed you changed the name of the package and the instructions etc, and that's totally fine.