search

sheharyarn / cloudup.dev

Tools to jump-start development on the Cloud ☁️
https://cloudup.dev
106 stars 11 forks source link

Incorrect ENV Variable Syntax in Dockerfile #12

Closed am-nimrah closed 8 months ago

am-nimrah commented 8 months ago

In the second stage of the Dockerfile, the ENV APP_NAME @{APP_NAME} statement uses incorrect syntax for variable substitution. Please correct it to the following: ENV APP_NAME ${APP_NAME} This ensures that the APP_NAME environment variable is set properly using the correct syntax.

sheharyarn commented 8 months ago

The Dockerfile generator in Cloudup uses a special substitution/replacement strategy that's transparent to the end-user. This allows the user to configure rarely modified variables at run-time and see the changes reflected immediately.

See this for reference:

https://github.com/sheharyarn/cloudup.dev/blob/4d64bd8aa8158ae6ce599d37f1db818182ecbd0a/src/templates/Docker/VariantTemplate.js#L30-L42