search

sheharyarn / cloudup.dev

Tools to jump-start development on the Cloud ☁️
https://cloudup.dev
106 stars 11 forks source link

Update and rename dockerfile to Dockerfile #24

Open am-nimrah opened 10 months ago

am-nimrah commented 10 months ago

Closes #25.

The Dockerfile has been streamlined by removing unnecessary comments and improving readability. The ARG NODE_VERSION="14" sets a default Node.js version, and unnecessary comments and placeholders were eliminated for brevity. The --production and --no-optional flags were added to the npm install command to exclude dev dependencies, reducing the image size. Exposed port 3000 was set as a default, and unnecessary COPY statement was removed. Overall, the Dockerfile is now more concise while maintaining its functionality.

sheharyarn commented 10 months ago

Thank you for sending a PR! 🌟

We use an internal file representation that's transparent to the user which helps us to manage various filetypes. This is different from actual/accurate file names, which are visible in the UI.

Can you please keep the filename same, i.e. dockerfile instead of Dockerfile, and update the PR to reflect these changes?

am-nimrah commented 10 months ago

Thank you for sending a PR! 🌟

We use an internal file representation that's transparent to the user which helps us to manage various filetypes. This is different from actual/accurate file names, which are visible in the UI.

Can you please keep the filename same, i.e. dockerfile instead of Dockerfile, and update the PR to reflect these changes?

Sure