search

sheinbergon / dremio-udf-gis

OGC/GIS functions and extensions for Dremio
Apache License 2.0
24 stars 1 forks source link

CompileException: Unknown variable or type "FunctionHelpersXL". #5

Closed bigfacewo closed 2 years ago

bigfacewo commented 2 years ago

Dremio was compiled in "JDK1.8", so I tried to compile "dremio-udf-gis" myself.

After modifying part of the code, I'm in jdk1.8 compilation succeeded. Removed unsupported syntax in 1.8.

But in actual use, it is wrong:

20220427-145038

sheinbergon commented 2 years ago

Hi @bigfacewo.

First of all, you can just run Dremio compiled for JDK8 with this jar under JDK11 and it'll work. You don't need to compile anything for JDK 11 on your own. Dremio compiles everything from scratch anyway, so it doesn't matter.

For compatibility purposes, I'll change the target to jdk 1.8 in the next release (scheduled for next week)

Second, when you changed the code, Did you make sure include full path import?

sheinbergon commented 2 years ago

1) ST_GeomFromText expects WKT, not WKB 2) If you'd like to send me a sample data set, I'll happily go over it 3) The error indicates some live compilation issue (Dremio compiles the source code from scratch). I did not encounter these issues in the cluster I'm running this extension on. Care to share more details about your setup?

sheinbergon commented 2 years ago

Duplicate of #6 . I'm closing this issue. let's follow up there

sheinbergon commented 2 years ago

@bigfacewo JIC - See updates here. Please try it out and let me know.

10x

sheinbergon commented 2 years ago

@bigfacewo have you gotten round to testing the new version in here

sheinbergon commented 2 years ago

@bigfacewo release 0.2.3 should address your issues.

bigfacewo commented 2 years ago

@sheinbergon It‘s working. Thank you. You have done a great job.

sheinbergon commented 2 years ago

No problem. Aside from documentation, would love to hear about missing/desired ST_* functions you'd like me to add (Separate issues, of course).