search

shekohex / allo-isolate

Run Multithreaded Rust along with Dart VM (in isolate) 🌀
Apache License 2.0
120 stars 18 forks source link

Fix bug that `u32`'s IntoDart will make the value completely wrong #17

Closed fzyzcjy closed 2 years ago

fzyzcjy commented 2 years ago

Please refer to https://github.com/fzyzcjy/flutter_rust_bridge/issues/234 for details.

shekohex commented 2 years ago

Thanks for the fix looks good to me, could we write a quick unit test for that? to make sure it is working?

Somewhere near here? Like a new function here to test big numbers and return them back and assert the result is the same.

fzyzcjy commented 2 years ago

Somewhere near here? Like a new function here

hmm where is "here"?

shekohex commented 2 years ago

Somewhere near here? Like a new function here

hmm where is "here"?

Oh sorry forgot to mention the file hahaha, there in the containers.rs

fzyzcjy commented 2 years ago

ok

fzyzcjy commented 2 years ago

done

shekohex commented 2 years ago

Perfect! Thank you, will publish a new version shortly.

fzyzcjy commented 2 years ago

You are welcome! Looking forward to it

shekohex commented 2 years ago

Published and included in v0.1.12 🎉

fzyzcjy commented 2 years ago

🎉