shekohex / allo-isolate

Run Multithreaded Rust along with Dart VM (in isolate) 🌀
Apache License 2.0
120 stars 18 forks source link

adds anyhow support #23

Closed lattice0 closed 2 years ago

lattice0 commented 2 years ago

Adds optional support for implementing IntoDart for anyhow, needed on https://github.com/fzyzcjy/flutter_rust_bridge/issues/533

fzyzcjy commented 2 years ago

This is blocking downstream library flutter_rust_bridge. May I know when will it be merged? Thanks

/cc @jerel @shekohex (not sure who is maintaining this lib)

shekohex commented 2 years ago

any updates on this @lattice0 and @fzyzcjy ?

lattice0 commented 2 years ago

Will we go with a simple string @fzyzcjy?

fzyzcjy commented 2 years ago

@lattice0 As suggested above

Hmm I am wondering whether this is sufficient or not? By https://docs.rs/anyhow/1.0.58/anyhow/struct.Error.html, seems that the debug format {:?} prints out more information? Or, if we want more structured solutions we can format it by ourselves

At least maybe use {:?} so we have more info

shekohex commented 2 years ago

Try cargo +nightly format then push your changes.

lattice0 commented 2 years ago

cargo +nightly fmt

changed 6 files, is it ok to push?

shekohex commented 2 years ago

Yup!

shekohex commented 2 years ago

Thank you, will publish a new version very soon!

shekohex commented 2 years ago

Released in v0.1.13.