search

shekohex / impulse

🎇 send a push notification when your long build command finish
http://impulse-build.netlify.app
MIT License
61 stars 1 forks source link

Safari compatibility #4

Open treuherz opened 4 years ago

treuherz commented 4 years ago

I think this project looks really useful, but my primary browser is Safari and the netlify site doesn't seem to prompt for notifications permissions with Safari. It looks from OneSignal's documentation like Safari compatibility requires a little additional setup. I realise this special case is Apple's fault not yours, but would it be possible to implement this?

shekohex commented 4 years ago

I added it, once #5 get merged, Could you give it a test?

treuherz commented 4 years ago

It now correctly requests notification permissions but then when fetching the User ID it comes back null and nothing is printed. OneSignal User ID: – null is logged to the console.