shelcia / dynamic-portfolio

Dynamic Portfolio helps you create simple websites by just filling out forms.
https://dynamic--portfolio.vercel.app/
32 stars 75 forks source link

Scroll to top issue resolved #284

Closed codemaniac-sahil closed 1 year ago

codemaniac-sahil commented 1 year ago

Hey, @shelcia I tried to resolve the scroll to top issue. Please check.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
dynamic-portfolio ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 20, 2023 at 0:30AM (UTC)
codemaniac-sahil commented 1 year ago

@shelcia, would you please merge this branch.

shelcia commented 1 year ago

@codemaniac-sahil have reviewed and added comments Please resolve it

codemaniac-sahil commented 1 year ago

@shelcia, would you please tell me what are you trying to say. I am no getting it.

shelcia commented 1 year ago

@shelcia, would you please tell me what are you trying to say. I am no getting it.

Add your styling in .scss file not directly into css. These are sass file which are to be compiled into css

codemaniac-sahil commented 1 year ago

Okay @shelcia

codemaniac-sahil commented 1 year ago

@shelcia, It is done. Would you please check.

codemaniac-sahil commented 1 year ago

@shelcia, I have done some changes. Please check.

shelcia commented 1 year ago

Screenshot 2023-02-13 at 7 23 02 PM Screenshot 2023-02-13 at 7 23 15 PM TEST IS OVERLAPPING in your commit

codemaniac-sahil commented 1 year ago

@shelcia, Okay, I am working on it.

codemaniac-sahil commented 1 year ago

@shelcia, Please check my new commit, I resolved the issue which is mentioned above.

shelcia commented 1 year ago

The code is redundant. Please create the component in one file and utilise whenever needed

shelcia commented 1 year ago

Remove the border, icon should be moved parallel to theme icon. Style the icons similar to theme toggle button.

Screenshot 2023-02-18 at 7 33 02 PM

codemaniac-sahil commented 1 year ago

@shelcia, okay I am working on it.

codemaniac-sahil commented 1 year ago

@shelcia, Please check my new commit Screenshot from 2023-02-20 18-01-14