search

shelfgot / TorahLibraryAddOnForDocs

A Google Docs add-on for Sefaria, currently published as "Sefaria Library" in the Google Workspace Marketplace.
10 stars 1 forks source link

Inserting a deep reference to Rashi comes up blank #25

Closed EliezerIsrael closed 9 years ago

EliezerIsrael commented 9 years ago

Example: Rashi on Genesis 45:5:1

There is content there, but it doesn't show up in the preview, and is blank if inserted into the document.

shelfgot commented 9 years ago

That isn't a good example, as there is no content there, as evidenced by a look at http://jsonviewer.stack.hu/#http://www.sefaria.org/api/texts/Rashi_on_Genesis.45:1:1?context=0&commentary=0

shelfgot commented 9 years ago

Rashi on Genesis 1:1:1 works. As far as I know, there is no problem here. What really needs to be fixed is the empty nodes in #24.

EliezerIsrael commented 9 years ago

It was 45:5:1 that I pointed to, but that was my mistake. For whatever reason that node is empty, but 45:5:2 is full. Putting in a ref to "Rashi on Genesis 45:5:2" does in fact work. This is a non-bug.

shelfgot commented 9 years ago

I had a feeling...it is always good to be vigilant, though.

On Tue, Dec 23, 2014 at 4:44 PM, Lev Eliezer Israel < notifications@github.com> wrote:

It was 45:5:1 that I pointed to, but that was my mistake. For whatever reason that node is empty, but 45:5:2 is full. Putting in a ref to "Rashi on Genesis 45:5:2" does in fact work. This is a non-bug.

— Reply to this email directly or view it on GitHub https://github.com/shman/SefariaAddOn-Google/issues/25#issuecomment-68001895 .

Shlomi D. Helfgot. Newest Project: psite.html, using VH, VW, and VMIN!