search

shelfgot / TorahLibraryAddOnForDocs

A Google Docs add-on for Sefaria, currently published as "Sefaria Library" in the Google Workspace Marketplace.
10 stars 1 forks source link

Inserting text from search #26

Closed alumerman closed 9 years ago

alumerman commented 9 years ago

When I performed a search, I could always preview the text but sometimes I couldn't insert the text.

shelfgot commented 9 years ago

Is there a pattern to the "sometimes"? Can you tell me 5 references that were inserted, and 5 that weren't?

alumerman commented 9 years ago

Hi -- Here's what I recall from the first time around.

-I couldn't insert the haftarah. -It took multiple tries and page refresh to get a few passages from exodus. +I had no trouble inserting the first two passages on my sheet (genesis rabbah and talmud yoma)

But...I just tried again and it was working well. A short delay when I clicked insert but not an unreasonable amount of time. Maybe it was my internet connection? I'm on a different network than I was before.

shelfgot commented 9 years ago
  1. I fixed the issue with the Haftarah (which was really an issue with any text spanning more than a perek.)
  2. Not sure about the second one..might be an internet issue, because that has always worked for me.
  3. I fixed the problem with the Talmud Yoma (which was underlying all of the texts) about 30 min. ago, and I updated your script accordingly. If you reinsert the source, you'll find that it behaves as expected.
alumerman commented 9 years ago

Great!

On Tue, Dec 23, 2014 at 6:55 PM, Shlomi Helfgot notifications@github.com wrote:

  1. I fixed the issue with the Haftarah (which was really an issue with any text spanning more than a perek.)
  2. Not sure about the second one..might be an internet issue, because that has always worked for me.
  3. I fixed the problem with the Talmud Yoma (which was underlying all of the texts) about 30 min. ago, and I updated your script accordingly. If you reinsert the source, you'll find that it behaves as expected.

— Reply to this email directly or view it on GitHub https://github.com/shman/SefariaAddOn-Google/issues/26#issuecomment-68021421 .

Annie Lumerman Director of Operations The Sefaria Project http://www.sefaria.org 650-600-8148 (o)

Why Funding the Jewish Project You’ve Never Heard of is a Big Deal http://ejewishphilanthropy.com/why-funding-the-jewish-project-youve-never-heard-of-is-a-big-deal/ facebook.com/sefaria.org https://www.facebook.com/sefaria.org @sefariaproject https://twitter.com/SefariaProject