search

shelfio / chrome-aws-lambda-layer

58 MB Google Chrome to fit inside AWS Lambda Layer compressed with Brotli
MIT License
667 stars 46 forks source link

updated to puppeteer 5.2 #20

Closed jnd0 closed 4 years ago

jnd0 commented 4 years ago

Updated to the last Puppeteer available version

vladholubiev commented 4 years ago

Thanks!

Could you please commit .zip file using Git LFS?

See https://git-lfs.github.com/

B/c GitHub now thinks file size increased by 350000%

image

jnd0 commented 4 years ago

I think I've done on the last commit

vladholubiev commented 4 years ago

New layer version published:

arn:aws:lambda:us-east-1:764866452798:layer:chrome-aws-lambda:19

see readme for the rest of the regions

jnd0 commented 4 years ago

Thank you so much for publishing this.

I've tried it and unfortunately doesn't work.

I get the following output when trying to execute this latest version of the layer 

{
  "code": "MODULE_NOT_FOUND",
  "requireStack": [
    "/opt/nodejs/node_modules/chrome-aws-lambda/source/puppeteer/lib/Browser.js",
    "/opt/nodejs/node_modules/chrome-aws-lambda/source/index.js",
    "/var/task/index.js",
    "/var/runtime/UserFunction.js",
    "/var/runtime/index.js"
  ]

I think is related to this: https://github.com/alixaxel/chrome-aws-lambda/pull/157

Should've checked before creating the merge request. Sorry

I will open a new one as soon as this gets fixed.

vladholubiev commented 4 years ago

Np @jnd0! I'll publish your fix once the upstream issue is resolved

jnd0 commented 4 years ago

Created merge https://github.com/shelfio/chrome-aws-lambda-layer/pull/24

This will fix the mess that has been created here as well as updating Puppeteer to the latest available version,

It will work this time I've checked manually creating my own layer before creating this pull request.

Thanks again @vladgolubev this was not too bad in the end for my first ever public merge request on GitHub 😅