search

shelfio / jest-mongodb

Jest preset for MongoDB in-memory server
MIT License
587 stars 83 forks source link

feat: increase mongodb version #443

Closed icco closed 7 months ago

icco commented 7 months ago

This does a few things:

vladholubiev commented 7 months ago

@harazdovskiy could you please take a look if nothing breaks, tests pass, and publish a new version?

harazdovskiy commented 7 months ago

Checked locally, merging! Thanks @icco for being patient and crafting this pull request❤️

CleanShot 2023-11-23 at 00 57 15@2x

harazdovskiy commented 7 months ago

@icco you can try changes in v4.2.0

icco commented 7 months ago

Thank you!

erosval commented 7 months ago

Thank you! Unfortunately, the test cases I implemented now no longer work as before when switching from mongodb driver 5.9.1 to 6.3.0.

I have several test cases and it would be complicated to report them but some queries return "undefined", does this happen to others too?

icco commented 7 months ago

Thank you! Unfortunately, the test cases I implemented now no longer work as before when switching from mongodb driver 5.9.1 to 6.3.0.

I have several test cases and it would be complicated to report them but some queries return "undefined", does this happen to others too?

Did you follow Mongo's upgrade documentation? https://www.mongodb.com/docs/drivers/node/current/upgrade/#version-6.x-breaking-changes we're still rolling out, but some of the return objects have changed.

erosval commented 7 months ago

Yes of course, when I run tests on a real mongodb database (v.7) everything works as expected

icco commented 7 months ago

Interesting, I haven't seen that yet. Let's create a new issue and try and figure it out?