Closed bjalt closed 2 years ago
Wow, great!
Could you please also update this line? So the docker image has a proper tag
https://github.com/shelfio/libreoffice-lambda-base-image/blob/master/.circleci/config.yml#L45
@vladgolubev What about https://github.com/shelfio/libreoffice-lambda-base-image/blob/master/.circleci/config.yml#L15? Should that be changed as well?
@bjalt yeap, there as well! Good catch. Probably could be refactored to reuse variables, like
parameters:
lo_version: xxx
# ....
tag: << pipeline.lo_version >>
@vladgolubev I haven't worked with circleCI yet. Looking through the documentation it should probably be like:
parameters:
lo_version: xxx
# ....
tag: << pipeline.parameters.lo_version >>
Can you confirm?
@bjalt correct
@vladgolubev Changed as requested.
fixes #8