shelfio / libreoffice-lambda-base-image

MIT License
30 stars 19 forks source link

chore: upgrade LibreOffice to version 7.4.0 #9

Closed bjalt closed 2 years ago

bjalt commented 2 years ago

fixes #8

vladholubiev commented 2 years ago

Wow, great!

Could you please also update this line? So the docker image has a proper tag

https://github.com/shelfio/libreoffice-lambda-base-image/blob/master/.circleci/config.yml#L45

bjalt commented 2 years ago

@vladgolubev What about https://github.com/shelfio/libreoffice-lambda-base-image/blob/master/.circleci/config.yml#L15? Should that be changed as well?

vladholubiev commented 2 years ago

@bjalt yeap, there as well! Good catch. Probably could be refactored to reuse variables, like

parameters:
  lo_version: xxx

# ....
tag: << pipeline.lo_version >>
bjalt commented 2 years ago

@vladgolubev I haven't worked with circleCI yet. Looking through the documentation it should probably be like:

parameters:
  lo_version: xxx

# ....
tag: << pipeline.parameters.lo_version >>

Can you confirm?

vladholubiev commented 2 years ago

@bjalt correct

bjalt commented 2 years ago

@vladgolubev Changed as requested.