shelfio / libreoffice-lambda-layer

MIT License
112 stars 22 forks source link

Doesn't work with nodejs10.x/nodejs12.x #16

Closed RimashMohomed closed 4 years ago

RimashMohomed commented 4 years ago

Trying to deploy with nodejs10.x, which result in a error.

"Error: The module '/opt/node_modules/@shelf/aws-lambda-brotli-unpacker/src/iltorb/build/bindings/iltorb.node'\nwas compiled against a different Node.js version using\nNODE_MODULE_VERSION 57. This version of Node.js requires\nNODE_MODULE_VERSION 64. Please try re-compiling or re-installing\nthe module (for instance, usingnpm rebuildornpm install).",

As the error suggest layer is built in NODE MODULE VERSION 57 but the nodejs10.x requires to be built in NODE MODULE VERSION >= 64

Can i have a build in NODE MODULE VERSION >= 64 ?

vladholubiev commented 4 years ago

Hey @RimashMohomed

This is due to Node.js 10 environment runs on Amazon Linux 2, while this layer was compiled for Amazon Linux 1. We're working on making it work with newer environments at the moment. I'll let you know once it works with Node.js 10 or 12

RimashMohomed commented 4 years ago

@vladgolubev Thanks for the update.

We are expecting to use this layer in production environment, do you find any reason not to ? and Is there any ETL for the Amazon Linux 2 build?

vladholubiev commented 4 years ago

@RimashMohomed Amazon Linux 2 build is due to this week thanks to @maaraanas!

You should be fine using it in production. The only risk is a vulnerability in the LibreOffice itself. But this can be mitigated by granting minimum required privileges to your Lambda.

RimashMohomed commented 4 years ago

@vladgolubev thank you for the quick response, will close the issue after testing !!

@maaraanas thank you for the contribution

RimashMohomed commented 4 years ago

@vladgolubev Is this done? where i can find the ARN and If i am to use with https://github.com/shelfio/aws-lambda-libreoffice how to do ?

andymccullough commented 4 years ago

also interested in hearing about the progress of this - i'd love to be able to use it for node 12, thanks!

vladholubiev commented 4 years ago

Good news: I was able to compile & run LibreOffice in the Node.js 12.x environment. Bad news: its size is ~400 MB

The goal is to make it <250 MB when unzipped, which is what I'm working on right now

RimashMohomed commented 4 years ago

@vladgolubev Any chance ?

tadasauciunas commented 4 years ago

Do I understand correctly that it's currently impossible to use the layer successfully with any version of node in aws ? Are there no temporary workarounds?

vladholubiev commented 4 years ago

Hey @tadasauciunas and other folks

We've just published a new version that works with nodejs10.x/nodejs12.x 🎉

https://github.com/shelfio/libreoffice-lambda-layer#version-arns

Thanks for your patience!

tadasauciunas commented 4 years ago

Thank you !

RimashMohomed commented 4 years ago

@vladgolubev thanks a lot, does the npm package is released as well? I assume version 3.0.0 is with these changes ?

I get below error is there any changes to do in the lambda function or layers. no such file or directory, open '/opt/lo.tar.br'"

tadasauciunas commented 4 years ago

@RimashMohomed Did you update the layer on which you depend after upgrading to the 3.0.0 package version ? See updated layer ARNs in the readme file of this repository

RimashMohomed commented 4 years ago

@tadasauciunas yes it solved the particular issue, but now layer sized exceeds max limit (250mb), as i using two more layers.