search

shell-pool / shpool

Think tmux, then aim... lower
Apache License 2.0
1.03k stars 13 forks source link

"Detach" action in README #45

Closed samgriesemer closed 1 week ago

samgriesemer commented 1 week ago

Minor detail from the README, but when setting up my config file with the block

[[keybinding]]
binding = "Ctrl-a d"
action = "Detach"

shpool complains about the action name after restarting:

unknown variant `Detach`, expected `detach` or `noop`

This should presumably just be updated to action = "detach" for those of us just copy-pasting this into a new config file.

ethanpailes commented 1 week ago

Oh, thanks for catching this. This is a holdover from before I was lowercasing enum identifiers in the config parsing.

ethanpailes commented 1 week ago

I'm bundling the fix into https://github.com/shell-pool/shpool/pull/39

thiswillbeyourgithub commented 1 week ago

Stumbled upon this one too. The lack of error message when trying to attach is an issue. I had to peek through the logs to figure it out