shell-pool / shpool

Think tmux, then aim... lower
Apache License 2.0
1.17k stars 20 forks source link

Configuration loading overhaul #58

Closed Aetf closed 4 months ago

Aetf commented 4 months ago

Please see the commit message for a more detailed description of the change.

@ethanpailes currently, the config merging rule is very simple: higher-priority top-level keys always fully overwrite lower-priority ones. However we should probably handle arrays and maps differently. Let me know what you think is the best strategy.

Also the PR is fairly large, let me know how I can make it easier to review.

Aetf commented 4 months ago

Sure, just force pushed to fix all those.

Edit: not quite :/ will make sure fixing lints before merge.

Thank you for the detailed review!