search

shellfly / django-vote

Simple vote for django
http://django-vote.readthedocs.io
Apache License 2.0
158 stars 49 forks source link

cascade on content type delete #61

Closed philippeluickx closed 6 years ago

philippeluickx commented 6 years ago

https://github.com/shanbay/django-vote/issues/60

shellfly commented 6 years ago

It should be on_delete=models.CASCADE because on_delete is not the first argument under Django version 1.9

philippeluickx commented 6 years ago

@shellfly that is a very good point, thanks for pointing that out. Will update.

codecov-io commented 6 years ago

Codecov Report

Merging #61 into master will decrease coverage by 0.41%. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #61      +/-   ##
=======================================
- Coverage   92.41%   92%   -0.42%     
=======================================
  Files           7     4       -3     
  Lines         211   150      -61     
  Branches       14    12       -2     
=======================================
- Hits          195   138      -57     
+ Misses         13     9       -4     
  Partials        3     3
Impacted Files Coverage Δ
vote/templatetags/__init__.py
vote/tests.py

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8036dda...3cd2b61. Read the comment docs.