shellfly / django-vote

Simple vote for django
http://django-vote.readthedocs.io
Apache License 2.0
158 stars 49 forks source link

Fix vote_exists template tag for django 2.0 #63

Closed DoctorJohn closed 6 years ago

DoctorJohn commented 6 years ago

Related to issue #62

codecov-io commented 6 years ago

Codecov Report

Merging #63 into master will decrease coverage by 0.44%. The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage      92%   91.55%   -0.45%     
==========================================
  Files           4        4              
  Lines         150      154       +4     
  Branches       12       14       +2     
==========================================
+ Hits          138      141       +3     
  Misses          9        9              
- Partials        3        4       +1
Impacted Files Coverage Δ
vote/templatetags/vote.py 92.85% <80%> (-7.15%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ab2466e...c070735. Read the comment docs.

shellfly commented 6 years ago

@DoctorJohn Nice work, can you also add some test for this, that will be better.

FYI you can change .travis.yml to add test for Django 2.0

tooooolong commented 6 years ago

great job

On May 4, 2018, 10:24 PM +0800, shellfly notifications@github.com, wrote:

@DoctorJohn Nice work, can you also add some test for this, that will be better. FYI you can change .travis.yml to add test for Django 2.0 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

DoctorJohn commented 6 years ago

Furtunately there is already a test in place (good job guys). I tried to add django 2.0 to travis.yml. Django 2.0 requires python 3. Dunno whether I added django 2.0 correctly.

shellfly commented 6 years ago

@DoctorJohn you can add Django 2.0 to env and exclude 2.7 in exclude block below

DoctorJohn commented 6 years ago

@shellfly like so?

shellfly commented 6 years ago

@DoctorJohn Exactly, LGTM, I will merge this, thanks for you work.

shellfly commented 6 years ago

@DoctorJohn FYI I have made a new release for your pull request, you can install django-vote==2.1.7 if you need.

DoctorJohn commented 6 years ago

Thanks!