Closed DoctorJohn closed 6 years ago
Merging #63 into master will decrease coverage by
0.44%
. The diff coverage is80%
.
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
- Coverage 92% 91.55% -0.45%
==========================================
Files 4 4
Lines 150 154 +4
Branches 12 14 +2
==========================================
+ Hits 138 141 +3
Misses 9 9
- Partials 3 4 +1
Impacted Files | Coverage Δ | |
---|---|---|
vote/templatetags/vote.py | 92.85% <80%> (-7.15%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ab2466e...c070735. Read the comment docs.
@DoctorJohn Nice work, can you also add some test for this, that will be better.
FYI you can change .travis.yml
to add test for Django 2.0
great job
On May 4, 2018, 10:24 PM +0800, shellfly notifications@github.com, wrote:
@DoctorJohn Nice work, can you also add some test for this, that will be better. FYI you can change .travis.yml to add test for Django 2.0 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
Furtunately there is already a test in place (good job guys). I tried to add django 2.0 to travis.yml. Django 2.0 requires python 3. Dunno whether I added django 2.0 correctly.
@DoctorJohn you can add Django 2.0 to env
and exclude 2.7 in exclude
block below
@shellfly like so?
@DoctorJohn Exactly, LGTM, I will merge this, thanks for you work.
@DoctorJohn FYI I have made a new release for your pull request, you can install django-vote==2.1.7
if you need.
Thanks!
Related to issue #62