shelljs / shx

Portable Shell Commands for Node
MIT License
1.72k stars 44 forks source link

fix: better regex support for sed #110

Closed nfischer closed 7 years ago

nfischer commented 7 years ago

Now works with using the empty string as a replacement string

Some details on allowed regexes (in unix sed):

Fixes #109

codecov-io commented 7 years ago

Current coverage is 100% (diff: 100%)

Merging #110 into master will not change coverage

@@           master   #110   diff @@
====================================
  Files           3      3          
  Lines          22     22          
  Methods         0      0          
  Messages        0      0          
  Branches        0      0          
====================================
  Hits           22     22          
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update 19c57ce...ef81e82

nfischer commented 7 years ago

@freitagbr could you review?

freitagbr commented 7 years ago

LGTM.