shelljs / shx

Portable Shell Commands for Node
MIT License
1.73k stars 45 forks source link

Handle input directly from npm scripts #118

Closed danielbayley closed 7 years ago

danielbayley commented 7 years ago

Alleviate the need to prefix scipts with shx. Fixes #117.

codecov-io commented 7 years ago

Codecov Report

Merging #118 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #118   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          22     24    +2     
=====================================
+ Hits           22     24    +2
Impacted Files Coverage Δ
src/shx.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a73e66d...42ce893. Read the comment docs.

danielbayley commented 7 years ago

@nfischer I was doing some digging around this, including hacking together a pretty naive package to translate basic stuff within npm scripts to windows cmd.exe equivalents before executing them (based on process.platform), then I came full circle across cash, along with this issue https://github.com/npm/npm/issues/11291, and basically I agree with the last comment (from yourself incidentally 😄) that cash is a much better fit for the goal I wanted, which is basically writing unixy commands in scripts without having to even acknowledge that Windows exists!

So I should probably redirect my efforts into contributing to that project, and hopefully one day it might even ship with npm!

So I’ll close this, but feel free to take whatever from it.

I’m wondering what the use case for shx is now, with cash in existence? There feels like a need to consolidate community efforts around a single solution.

nfischer commented 7 years ago

Let's continue discussion at dthree/cash#75. I think that's a better solution for your issue 😄