search

shelljs / shx

Portable Shell Commands for Node
MIT License
1.72k stars 44 forks source link

chore(CI): add node v10 to CI #131

Closed nfischer closed 6 years ago

nfischer commented 6 years ago

This adds Node v10 to Appveyor and Travis CI.

nfischer commented 6 years ago

Appveyor failures are due to #132, this PR is OK.

codecov-io commented 6 years ago

Codecov Report

Merging #131 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #131   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          22     22           
=====================================
  Hits           22     22

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 63bdaa4...7d19cd6. Read the comment docs.

nfischer commented 6 years ago

Rebased off master, so I don't expect any CI failures.

nfischer commented 6 years ago

I think it's OK to land this before https://github.com/shelljs/shelljs/pull/856. I don't think that reflects a significant node-v10-incompatibility in shelljs.

freitagbr commented 6 years ago

LGTM