search

shelljs / shx

Portable Shell Commands for Node
MIT License
1.72k stars 44 forks source link

feat(version): support --version flag #138

Closed nfischer closed 6 years ago

nfischer commented 6 years ago

This adds support for the --version CLI flag. This outputs the version number for both shx and the bundled version of ShellJS. This adds a test to strictly assert the output format, so that this can be reliably parsed if necessary.

This also reorganizes the structure of some test cases (without changing their logic).

Lastly, this changes the file modes for 2 files. These were previously unnecessarily executable.

Fixes #111 Test: case: 'supports --version'

codecov-io commented 6 years ago

Codecov Report

Merging #138 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #138   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          22     25    +3     
=====================================
+ Hits           22     25    +3
Impacted Files Coverage Δ
src/printCmdRet.js 100% <ø> (ø) :arrow_up:
src/shx.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 63bdaa4...ecb1d38. Read the comment docs.

freitagbr commented 6 years ago

LGTM