shelljs / shx

Portable Shell Commands for Node
MIT License
1.72k stars 44 forks source link

New release with ShellJS v0.8.4 #185

Closed stevendesu closed 3 years ago

stevendesu commented 4 years ago

The version of shx on NPMJS still relies on ShellJS v0.8.1

In Node v14 this throws a bunch of warnings:

...
(node:49556) Warning: Accessing non-existent property 'cd' of module exports inside circular dependency
(node:49556) Warning: Accessing non-existent property 'chmod' of module exports inside circular dependency
(node:49556) Warning: Accessing non-existent property 'cp' of module exports inside circular dependency
(node:49556) Warning: Accessing non-existent property 'dirs' of module exports inside circular dependency
(node:49556) Warning: Accessing non-existent property 'pushd' of module exports inside circular dependency
(node:49556) Warning: Accessing non-existent property 'popd' of module exports inside circular dependency
(node:49556) Warning: Accessing non-existent property 'echo' of module exports inside circular dependency
(node:49556) Warning: Accessing non-existent property 'tempdir' of module exports inside circular dependency
(node:49556) Warning: Accessing non-existent property 'pwd' of module exports inside circular dependency
(node:49556) Warning: Accessing non-existent property 'exec' of module exports inside circular dependency
(node:49556) Warning: Accessing non-existent property 'ls' of module exports inside circular dependency
(node:49556) Warning: Accessing non-existent property 'find' of module exports inside circular dependency
(node:49556) Warning: Accessing non-existent property 'grep' of module exports inside circular dependency
(node:49556) Warning: Accessing non-existent property 'head' of module exports inside circular dependency
(node:49556) Warning: Accessing non-existent property 'ln' of module exports inside circular dependency
(node:49556) Warning: Accessing non-existent property 'mkdir' of module exports inside circular dependency
(node:49556) Warning: Accessing non-existent property 'rm' of module exports inside circular dependency
(node:49556) Warning: Accessing non-existent property 'mv' of module exports inside circular dependency
(node:49556) Warning: Accessing non-existent property 'sed' of module exports inside circular dependency
...

It looks like the ShellJS dependency in the package.json on master has been updated, but the version number in the package.json has not been updated and NPMJS has not been updated (last update was 2 years ago on NPMJS)

sachalifs commented 3 years ago

@stevendesu I was having the same issue and I fixed it by running yarn remove shx and yarn add shx. It seems this problem was being caused by another dependency.

nfischer commented 3 years ago

See https://github.com/shelljs/shx/releases/tag/v0.3.3