search

shells-dw / streamdeck-totalmix

Unofficial StreamDeck RME TotalMix FX Plugin - supporting MIDI and OSC
MIT License
51 stars 5 forks source link

interfaceIp setting does not work. #30

Closed roguedarkjedi closed 1 year ago

roguedarkjedi commented 1 year ago

The ip input value goes unused, and needs to be added to the original constructor otherwise the message will not be sent. Added address verification for input interfaceIp setting.

Attached pull request will allow for messages to be sent outside of the machine the steamdeck is connected to. Tested on local network.

roguedarkjedi commented 1 year ago

The same issue exists in the loupedeck as well and would also need to be fixed. Luckily the code could just be copied over.

shells-dw commented 1 year ago

Hey, thanks for pointing that out and taking the time making the PR! I fixed it with v3.3.5 however I didn't merge your PR. I've been coding around at times since the last release but didn't really get to finish anything, work has been crazy, so my local code was somewhat different and the PR didn't fit in 100% anymore, I had to change some other things to make it work (I think, I added some stuff in the last two months as well, so yeah) - I didn't want to mess around with that, hope that's fine with you. Anyway, it's fixed.

roguedarkjedi commented 1 year ago

No problem, thank you for fixing the issue