search

shellscape / Gmail-Notifier-Plus

Gmail Notifier Plus
http://shellscape.org
MIT License
90 stars 26 forks source link

The update mechanism is broken #132

Closed jansokoly closed 10 years ago

jansokoly commented 10 years ago

Gmail Notifier Plus periodically issues calls like this:

GET https://api.github.com/repos/shellscape/Gmail-Notifier-Plus/downloads HTTP/1.1
Host: api.github.com
Connection: Keep-Alive

That obviously is an update mechanism. What I keep seeing in Fiddler as a response is this:

HTTP/1.0 403 Forbidden
Cache-Control: no-cache
Connection: close
Content-Type: text/html

Request forbidden by administrative rules. Please make sure your request has a User-Agent header (http://developer.github.com/v3/#user-agent-required). Check https://developer.github.com for other possible causes.

To solve this, Shellscape.UpdateManager should set the User-Agent header when downloading the list. That could be

shellscape commented 10 years ago

This is actually in Shellscape.Common -> https://github.com/shellscape/Shellscape.Common/blob/master/Shellscape.Common/UpdateManager.cs

And it also needs to be updated to use the 'releases' function of github now, since they removed downloads from repos. I had actually moved the downloads here: https://bitbucket.org/shellscape/gmail-notifier-plus/downloads when Github did that.

I don't have an accessible windows machine at the moment, so I'm not sure when I'll be able to getting around to fixing this. I've switched almost exclusively over to mac in the last year.

shellscape commented 10 years ago

@jansokoly would you like contributor status on the repository? that would allow you to commit without pull requests (though it would still be nice to watch what's being done) and create new releases.

jansokoly commented 10 years ago

Well, I don't mind. If you're no longer able to maintain the project, I may throw in my 2 cents and help with reviewing bugfix pull requests.

shellscape commented 10 years ago

@jansokoly I've set you up with collaborator access to GNP's repo and Shellscape.Common.

jansokoly commented 10 years ago

Alright. How would you like me to add contributions from now on? Directly to the repo or pushing to my fork first, sending a pull request and merging it?

shellscape commented 10 years ago

I'd say whatever you feel most comfortable with.