search

shellscape / Gmail-Notifier-Plus

Gmail Notifier Plus
http://shellscape.org
MIT License
90 stars 26 forks source link

Shell32 doesn't have bitmap #632 in Win8 RP x64 #96

Closed SolalPirelli closed 12 years ago

SolalPirelli commented 12 years ago

GMail Notifier Plus crashes on the first run after clicking on "Let's go" because you're trying to load bitmap 632 in shell32.dll, which is not present in Win8 RP x64 for some reason.

PS: You should disable any exception logging/reporting when in debug mode - having to comment every use of the various "error helper" classes to see where the exception is thrown is pretty annoying :/

shellscape commented 12 years ago

Typically I don't debug Release Candidates, Betas, or pre-release builds of Windows since so much can change between builds.

I'd be willing to take the time to install the Release Preview and debug the issue if you make a reasonable donation for my time.

Or you can always fork the repo, fix the problem and file a pull request.

SolalPirelli commented 12 years ago

I don't have git, so here's a manual pull request :)

Insert the following at line 123 of Shellscape.Common/UI/Control Panel/ControlPanelNavigation.cs (in DrawBackground, just before the using()) : if ( _backgroundOverlay == null ) { _backgroundOverlay = Utilities.ResourceHelper.GetStandardResourceBitmap( "shell32.dll", "#633" ); }

shellscape commented 12 years ago

Github has a great GUI client for Windows now. If you'd like to get this in for the RP and next version of GNP, please go the fork/pull request route.

SolalPirelli commented 12 years ago

I already have Mercurial (and HgGit requires a bunch of dependencies), I don't want to install git.

Seems like I'll have to write my own GMail notifier. Not very hard (I need systray toasts mainly) but...manually adding three lines is too much?

shellscape commented 12 years ago

Follow the process or don't. Your call. If the problem exists in Win8 final, I'm sure I'll see and debug it at that point.

Feel completely free to use GNP's source in your efforts, I only ask that people attribute the source back the project.