shellscape / jsx-email

Build emails with a delightful DX
https://jsx.email
MIT License
897 stars 28 forks source link

fix(jsx-email): remove qr-code #117

Closed lordelogos closed 6 months ago

lordelogos commented 6 months ago

Component / Package Name:

jsx-email This PR contains:

Are tests included?

Breaking Changes?

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

This PR removes the QrCode component.

The component was never tested within the preview, and only worked within a server-side render or direct call to render. That combined with the fact that the data-uri format isn't widely supported means that this just isn't ready to be included. This is not a breaking change because the component was never correctly exported from jsx-email (oops).

shellscape commented 6 months ago

you probably need to run pnpm i and commit the lockfile update.