shellscape / jsx-email

Build emails with a delightful DX
https://jsx.email
MIT License
897 stars 28 forks source link

Previewer hang when using empty files and default arguments #125

Closed Gobot1234 closed 6 months ago

Gobot1234 commented 6 months ago

https://stackblitz.com/edit/jsx-email-repro-fcbu37?file=templates/Reproduction.tsx

Expected Behavior

The previewer should work

Actual Behavior

The previewer never loads

Additional Information

For the issue you need to move the footer.tsx file between test and templates. This seems to be interacting with default arguments weirdly because removing them makes everything work fine.

Gobot1234 commented 6 months ago

Issue was resolved by using a different folder for the footer component and importing from there

shellscape commented 6 months ago

We're still going to add some code to protect against this 👍