shellscape / jsx-email

Build emails with a delightful DX
https://jsx.email
MIT License
897 stars 28 forks source link

feat(jsx-email): use debug for data attribute rendering #147

Closed shellscape closed 5 months ago

shellscape commented 5 months ago

Component / Package Name:

This PR contains:

Are tests included?

Breaking Changes?

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

This PR changes up the data-id attribute to data-type, and removes the strip property from render options. Users can now use DEBUG=jsx-email:elements to enable adding the attribute to the output if desired.

While this is technically a breakingish change, we're moving forward with this as a minor version because it's so seldom used. This should also yield a speed increase as well.