shellscape / jsx-email

Build emails with a delightful DX
https://jsx.email
MIT License
895 stars 28 forks source link

fix(jsx-email): move preview app to peerDeps, isolation for preview tests #157

Closed shellscape closed 5 months ago

shellscape commented 5 months ago

Component / Package Name: jsx-email

This PR contains:

Are tests included?

Breaking Changes?

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

This PR changes the @jsx-email/app-preview dependency to a peerDependency to work around https://github.com/pnpm/pnpm/issues/6603, and allow for the preview tests to be run in isolation outside of the monorepo. This is important for a number of reasons; the primary one making sure that when dependencies are added or removed from the preview app, that the app itself doesn't break in dev mode.