fix(button): remove pX and pY from types - Githubissues

shellscape / jsx-email

Build emails with a delightful DX

https://jsx.email

MIT License

961 stars 31 forks source link

fix(button): remove pX and pY from types #20

Closed shellscape closed 11 months ago

shellscape commented 11 months ago

Component / Package Name:

This PR contains:

[x] bugfix
[ ] feature
[ ] refactor
[ ] documentation
[ ] other

Are tests included?

[ ] yes (bugfixes and features will not be merged without tests)
[x] no

Breaking Changes?

[ ] yes (breaking changes will not be merged unless absolutely necessary)
[x] no

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

Removes unused properties from component Props type, updates docs.

shellscape commented 11 months ago

This is one of those changes that are halfway between a bugfix and a breaking change. While removing properties from types is technically a breaking change, the properties being removed are effectively a no-op since v1.0.0. Going to release this as a fix (patch), and beg forgiveness for any pain this causes.