search

shellscape / jsx-email

Build emails with a delightful DX
https://jsx.email
MIT License
1.07k stars 36 forks source link

Incompatible with React Router 7 apps #246

Closed tobimori closed 1 week ago

tobimori commented 1 week ago

When installing jsx-email in a RR7 app, there are numerous errors that seem to be fixed when removing jsx-email:

image

shellscape commented 1 week ago

@tobimori was the issue template unclear about what is required when reporting an issue?

shellscape commented 1 week ago

If you'd like to report a proper issue, we'd welcome it. You're probably better off reporting this to the react-router project as this is more likely an upstream problem with react-router. Here's a direct link: https://github.com/remix-run/react-router/issues/new?assignees=&labels=bug&projects=&template=bug_report.yml&title=%5BBug%5D%3A+

tobimori commented 1 week ago

It's not an upstream issue, the incompatibility is in jsx-email because there are mismatching dependency versions installed.

tobimori commented 1 week ago

Also, which issue template? I didn't see one when creating a new issue?

shellscape commented 1 week ago

I'm a bit confused - based on your github profile this should not be new to you:

Screenshot 2024-11-23 at 10 40 27 AM Screenshot 2024-11-23 at 10 40 32 AM

If you'd like to open a new issue and follow our template, you're welcome to. Since this is nuanced to your environment, your reproduction should include the conditions that led to your error, as well as details about any information you gleaned during your triage. Worth noting that generic statements like "there are mismatching dependency versions installed" isn't very helpful, but actual details are helpful.

tobimori commented 1 week ago

I sent a video on Discord, I don't see this. I'd have certainly not ignored it!

Here's the reproduction repo: https://github.com/tobimori/jsx-email-repro