shellscape / jsx-email

Build emails with a delightful DX
https://jsx.email
MIT License
961 stars 31 forks source link

fix(tailwind): incorrect variable reference in processHead() #33

Closed phpnode closed 11 months ago

phpnode commented 11 months ago

Component / Package Name: @jsx-email/tailwind

This PR contains:

Are tests included?

Breaking Changes?

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

processHead() was previously returning child instead of processedChild, leading to duplicated output when using <Tailwind />

shellscape commented 11 months ago

awesome, thanks. will follow up when CI is done running

shellscape commented 11 months ago

OK as I thought, this was probably going to break the tests we have in place. Please run moon tailwind:test -- -u to update the test snapshots, and commit the updates.

shellscape commented 11 months ago

Here's a link to the diff for this change. Looks legit https://www.diffchecker.com/lkjdtOWr/

shellscape commented 11 months ago

Updated your branch with the test updates so we could get this fix out. Hope you don't mind :)