search

shellscape / jsx-email

Build emails with a delightful DX
https://jsx.email
MIT License
961 stars 31 forks source link

Is Bun supported? #39

Closed yannxaver closed 10 months ago

yannxaver commented 10 months ago

Documentation Is:

Please Explain in Detail...

The docs currently do not mention bun.

Your Proposal for Changes

If it is supported, it could be added to all the examples.

shellscape commented 10 months ago

Not sure! I'm not a Bun or Deno user. Good bet if Bun supports React.

We have a discord server and discussions for general Q & A, that's a better spot than issues. Feel free to open an issue with a reproduction with a filled-in template if something doesn't work right.

yannxaver commented 10 months ago

One of your issue templates says:

📚 Documentation Are the docs lacking or missing something? Do they need some new 🔥 hotness? Tell us here.

The issue seems in line with that, so I'm surprised about the reference to the Discord server.

shellscape commented 10 months ago

Well that's what I get for viewing on mobile :) Sorry for the misstep.

shellscape commented 10 months ago

@Jarred-Sumner anyone on staff that could give this a spin with bun to answer OP's question of support?

XMadFoX commented 10 months ago
Well, looks so (vite and react are supported, so why not) ![image](https://github.com/shellscape/jsx-email/assets/37180406/3d264af5-553c-418e-85a1-3b06e439d65d)
shellscape commented 10 months ago

That's good news! We'll update the docs very soon. Thanks for taking a look at that

XMadFoX commented 10 months ago

I am not on bun staff BTW 😳 But just followed try it and see

You may want to wait for their response

shellscape commented 10 months ago

The try it and see is good enough for me. That screenshot shows me what I needed to know.

side note: was it any faster?

XMadFoX commented 10 months ago

build ~2x faster image image

shellscape commented 10 months ago

alright bun support was pushed and should be visible on the sight in a few minutes! thanks @XMadFoX