shellscape / jsx-email

Build emails with a delightful DX
https://jsx.email
MIT License
902 stars 28 forks source link

fix(cli): Normalize globby path for cli build command #44

Closed bhuynhdev closed 8 months ago

bhuynhdev commented 8 months ago

Component / Package Name:

This PR contains:

Are tests included?

I used the existing test suite and did not make any new tests

Breaking Changes?

List any relevant issue numbers:

resolves #41

Description

As discussed in #41, the jsx-email's CLI build command use globby to search for file names to read, build, and write to. However, per https://github.com/sindresorhus/globby/issues/179, on Windows system, Globby won't work as Windows path contains backslashes but Globby only wants path with forward slashes. Therefore, a normalizePath function (inspired by rollup) was used to normalize the path so it would work on both Windows and UNIX systems

shellscape commented 8 months ago

Thanks for getting this in. Will merge as soon as CI is done.

In other news, pnpm has prioritized a fix for the issue that is preventing us from running the Windows CI workflow here. Hoping that we get a fix soon and can enable better Windows support in development.

shellscape commented 8 months ago

thanks!