shellscape / jsx-email

Build emails with a delightful DX
https://jsx.email
MIT License
902 stars 28 forks source link

fix(cli): make no-open preview option work correctly #52

Closed co-sic closed 8 months ago

co-sic commented 8 months ago

Component / Package Name:

This PR contains:

Are tests included?

Breaking Changes?

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

no-open option that is described in the help of the preview command is currently not working (throwing error since the validation expects a "open" boolean value)

shellscape commented 8 months ago

Thanks for the PR. FWIW this bug is from thinking like we're using yargs-parser, with the built-in parseArgs not working the same.

We'll merge this in as-is so you can use this fix immediately, but I'm going to pivot to yargs-parser later today.