search

shellscape / jsx-email

Build emails with a delightful DX
https://jsx.email
MIT License
991 stars 33 forks source link

remove target from Button/Link #81

Closed T04435 closed 10 months ago

T04435 commented 10 months ago

Expected Behavior / Situation

According to https://www.caniemail.com/features/html-target/ target attribute is not supported and forced to "_blank", s it's recommended not to add it.

<a href="#" data-id="@jsx-email/button">Link</a>

Actual Behavior / Situation

<a href="#" data-id="@jsx-email/button" target="_blank">Link</a>

Modification Proposal

Remove target from button thinking it also applies to Link component

<a href="#" data-id="@jsx-email/button" target="_blank">OLD</a>
<a href="#" data-id="@jsx-email/button">NEW</a>
lordelogos commented 10 months ago

Hi @T04435,

Thank you for pointing this out. Would you be interested in submitting a pull request to implement this proposal?

shellscape commented 10 months ago

Will get this change in this week.