search

shellscape / postcss-less

PostCSS Syntax for parsing LESS
MIT License
122 stars 39 forks source link

Fix inline comments including newlines #131

Closed jwilsson closed 5 years ago

jwilsson commented 5 years ago

Which issue # if any, does this resolve?

129

Please check one:

This PR:

codecov-io commented 5 years ago

Codecov Report

Merging #131 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   96.47%   96.49%   +0.01%     
==========================================
  Files           8        8              
  Lines         227      228       +1     
==========================================
+ Hits          219      220       +1     
  Misses          8        8
Impacted Files Coverage Δ
lib/nodes/inline-comment.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6e7bf62...baf8ee3. Read the comment docs.

shellscape commented 5 years ago

LGTM.

Question: Is this a fix or a breaking change? I can't arrive at a decision on that.

jwilsson commented 5 years ago

I wanna say it's a bug fix for a 3.0 regression, because the 2.0 behaviour was putting new lines in raws.before.

shellscape commented 5 years ago

Sounds good to me. 😅 here's hoping a patch doesn't bork the world. I'll get this published later on today. Thanks for getting a fix in.