life777 commented 3 years ago

**Which issue #145 if any, does this resolve?

Please check one:

[x] New tests created for this change
[ ] Tests updated for this change

This PR:

[ ] Adds new API
[ ] Extends existing API, backwards-compatible
[ ] Introduces a breaking change
[x] Fixes a bug

This fix is simple. Before when code finds a quote symbol in comment it overwrites an this.input and this.tokenizer before new token for the comment is created. It means when code tries to get a position by offset getPosition it searches for in in new input, but should in old one.

codecov-io commented 3 years ago

Codecov Report

Merging #154 (ebd3129) into master (d19dff9) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   97.38%   97.38%           
=======================================
  Files           3        3           
  Lines         153      153           
=======================================
  Hits          149      149           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d19dff9...ebd3129. Read the comment docs.

shellscape commented 3 years ago

Thanks for opening a PR for this :beer: I'll have a look early tomorrow.

life777 commented 3 years ago

@shellscape Are there any problems with my fix that I should change?

shellscape commented 3 years ago

thanks!

shellscape / postcss-less

Single comment with quote #154

Codecov Report