search

shellscape / postcss-less

PostCSS Syntax for parsing LESS
MIT License
122 stars 39 forks source link

Fix node positional information for files with single-quotes in comments #164

Closed nwalters512 closed 2 years ago

nwalters512 commented 3 years ago

This resolves issue #163.

Please check one:

This PR:

This PR is my attempt at resolving the issue described in #163. It makes the new tests I added pass, and it doesn't break any existing tests. Unfortunately, most of the existing tests don't assert anything about positional information, so it's pretty difficult for me to assert that this doesn't adversely impact anything else. I'd be happy to augment some existing tests with positional information to help increase confidence.

The change to lib/nodes/inline-comment.js was necessary to get the following assertion about the end position of a comment to pass:

t.is(innerCommentNode.source.end.column, 6);
codecov-commenter commented 3 years ago

Codecov Report

Merging #164 (83f0986) into master (c92f312) will increase coverage by 0.17%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   97.38%   97.56%   +0.17%     
==========================================
  Files           3        3              
  Lines         153      164      +11     
==========================================
+ Hits          149      160      +11     
  Misses          4        4
Impacted Files Coverage Δ
lib/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c92f312...83f0986. Read the comment docs.

shellscape commented 2 years ago

thanks!

nwalters512 commented 2 years ago

@shellscape do you have a rough estimate of when this will be released in a new version on npm?