search

shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests
MIT License
1.44k stars 185 forks source link

Improve documentation about `webpack-manifest-plugin-after-emit` hook. #103

Closed alexander-akait closed 3 years ago

alexander-akait commented 6 years ago

It will be great, thanks!

a-x- commented 6 years ago

Hey, I don't aware about webpack-manifest-plugin-after-emit hook so good.

This spec looks comprehensive: https://github.com/danethurber/webpack-manifest-plugin/blob/34257bc2da17c6f18ab64c4db938993d6143be47/spec/plugin.integration.spec.js#L68

We can add brief description and link to the spec.

a-x- commented 6 years ago

Isn't hooks options section fit your needs?

Can you describe your problem?

a-x- commented 6 years ago

I see that this hook added recently https://github.com/danethurber/webpack-manifest-plugin/pull/76

therefore, brief description might looks like this:

webpack-manifest-plugin-after-emit allows other plugins to use the manifest. Look at patch and spec for more details.

mastilver commented 6 years ago

yep, my bad, I shouldn't have merged that without the appropriate docs update

@a-x- Are you alright updating the doc?

a-x- commented 6 years ago

Ok, sure. it's almost done.

a-x- commented 6 years ago

https://github.com/danethurber/webpack-manifest-plugin/blob/doc/README.md#webpack-manifest-plugin-after-emit-hook

alexander-akait commented 6 years ago

@a-x- @mastilver friendly ping, not information in README after stable release

Lalitha-Iyer commented 6 years ago

is this hook available in webpack 4 ?

lili21 commented 5 years ago

@Lalitha-Iyer You can use it in webpack 4.

compiler.hooks.webpackManifestPluginAfterEmit.tap('MyPlugin', manifest => {
  //
})
shellscape commented 3 years ago

Hey all! I've taken over maintenance of the plugin and am doing some housecleaning. For Issues over a year old without a reproduction, we're going to go the route of closing them first. However, they're not dead! If the issue is still pending and still a problem, please reply with a reproduction and we'll reopen post-haste.

Please provide a reproduction by choosing one of the options below:

  1. Using the REPL.it plugin reproduction template at https://repl.it/@shellscape/manifest-plugin-repro

  2. Provide a minimal repository link (Read https://git.io/fNzHA for instructions). Please use NPM for installing dependencies! These may take more time to triage than the other options.

    ⚠️ ZIP Files are unsafe and maintainers will NOT download them.