search

shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests
MIT License
1.44k stars 185 forks source link

changed default filename from 'manifest.json' to 'manifest.webmanifest' #106

Closed mojoaxel closed 6 years ago

mojoaxel commented 6 years ago

Thanks for this plugin! 👍

This pull requests changes the default filename from manifest.json to manifest.webmanifest because this is (now) the recommended filename and extension by the W3C:

Here is the discussion:

Some browser vendors also already adopted there docs:

I would consider this a major change so maybe this is something for the major 2.0 release?

codecov-io commented 6 years ago

Codecov Report

Merging #106 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #106   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          78     78           
=====================================
  Hits           78     78
Impacted Files Coverage Δ
lib/plugin.js 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 409b0fb...46cc61a. Read the comment docs.

mojoaxel commented 6 years ago

Sorry my mistake. Wrong manifest.json ;-)