search

shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests
MIT License
1.43k stars 185 forks source link

fix: use multiple instances at the same time #107

Closed mastilver closed 6 years ago

mastilver commented 6 years ago

closes #100

codecov-io commented 6 years ago

Codecov Report

Merging #107 into master will increase coverage by 5.68%. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #107      +/-   ##
========================================
+ Coverage   94.31%   100%   +5.68%     
========================================
  Files           2      2              
  Lines          88     87       -1     
========================================
+ Hits           83     87       +4     
+ Misses          5      0       -5
Impacted Files Coverage Δ
lib/plugin.js 100% <100%> (+5.74%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 661af13...186bca5. Read the comment docs.

deguif commented 6 years ago

Regarding #100 discussion that means that's the multi instance solution that was chosen.

mastilver commented 6 years ago

@deguif Yeah, I really wasn't sure what was the right solution..., I think this is the most natural for the user, I hope it doesn't introduce any bugs...

deguif commented 6 years ago

@mastilver Yes, I totally agree. I find it better too. But from the discussion I was ready to play with an array of config.

deguif commented 6 years ago

Any news about this PR?