search

shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests
MIT License
1.44k stars 185 forks source link

Use individual lodash packages #112

Closed woodyrew closed 4 years ago

woodyrew commented 6 years ago

Only two packages from lodash are used. These have been added appropriately.

codecov-io commented 6 years ago

Codecov Report

Merging #112 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #112   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          78     78           
=====================================
  Hits           78     78
Impacted Files Coverage Δ
lib/plugin.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 409b0fb...3f30c39. Read the comment docs.

spoike commented 6 years ago

Is assign from lodash necessary?

Object.assign has been in Node since version 4 and this project's package.json specifies supporting Node >= 4.

spoike commented 6 years ago

This PR will most likely be in conflict with changes in #58 (suggestion to remove lodash completely).

woodyrew commented 4 years ago

58 and #166 have the same result, neither have been merged and there are conflicts now.

The full Lodash package is still in master ¯\_(ツ)_/¯